Skip to content

fix websocket #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix websocket #142

wants to merge 1 commit into from

Conversation

vitaliysemenko
Copy link

Fix websocket function definition and check param availability

@zentai
Copy link

zentai commented May 10, 2025

for this function, I think they calling wrong api,

def on_close(original_connection):
    websocket_connection = websocket_connection_handler[original_connection]
    websocket_connection.close().   <<< should be close() instead of on_close()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vitaliysemenko @zentai